From d52c1f5e4d21048aeda1a7341a5586baf0a2b820 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Mon, 28 Jan 2019 09:57:19 +0100 Subject: [PATCH 1/2] Fix vertical position of submit button in public share auth page MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The submit button in the chat view is positioned using its "bottom" property to align it with the bottom of the new message form even when there are several lines and the form grows vertically. "publicshareauth.css" (core) sets the "top" property of submit buttons, which causes the submit button in the chat view to be aligned to the top of the new message form, and thus needs to be overriden. Signed-off-by: Daniel Calviño Sánchez --- css/publicshareauth.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/css/publicshareauth.scss b/css/publicshareauth.scss index 9d2772facd5..af75f43852a 100644 --- a/css/publicshareauth.scss +++ b/css/publicshareauth.scss @@ -226,3 +226,9 @@ input#request-password-button:disabled ~ .icon { width: unset; margin: 0; } + +/* Unset conflicting rules from publicshareauth.css (core) for the sidebar */ +#talk-sidebar input[type="submit"], +#talk-sidebar input.icon-confirm[type="submit"] { + top: unset; +} From a853ea7872d535b50ccfdebf42990b2a12bee316 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Mon, 28 Jan 2019 10:15:32 +0100 Subject: [PATCH 2/2] Fix submit button not hidden in public share auth page MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit While a message is being sent the submit button in the chat view is hidden by setting the "hidden" CSS class to it. However, in "guest.css" an explicit "display" property is set for submit buttons; this rule is more specific than the generic rule for ".hidden" elements, and thus overrides it, causing the submit button to be shown even when the "hidden" CSS class is set. Therefore, an explicit rule is needed to set "display: none" for hidden submit buttons. Signed-off-by: Daniel Calviño Sánchez --- css/publicshareauth.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/css/publicshareauth.scss b/css/publicshareauth.scss index af75f43852a..6b0790d2d40 100644 --- a/css/publicshareauth.scss +++ b/css/publicshareauth.scss @@ -232,3 +232,9 @@ input#request-password-button:disabled ~ .icon { #talk-sidebar input.icon-confirm[type="submit"] { top: unset; } + +/* Unset conflicting rules from guest.css for the sidebar */ +#talk-sidebar input[type="submit"].hidden, +#talk-sidebar input.icon-confirm[type="submit"].hidden { + display: none; +}