Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new About window #917

Merged
merged 5 commits into from
Nov 22, 2024
Merged

feat: new About window #917

merged 5 commits into from
Nov 22, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Nov 21, 2024

☑️ Resolves

Making the About window more useful and beautiful.

Replacing package.json/version with git describe tag:

  • Just a tag to official release on the tagged commit, e.g., v1.0.1
  • Described with hash and branch otherwise, e.g. v1.0.1-80-g481b5e1 (heads/fix/help-system-report)

Updating the "About" window

  • Can be open with F1
  • New look
    • Large, just looks better (by @ShGKme opinion)
    • More unified look - old ugly close button was added only for macOS. Also, macOS has no title bar in modal windows
    • On macOS the quit button is on the left
  • Add context menu to about (help) window #126
  • The report is now a nice MD table with a copy button
  • Updated info:
    • Server URL is removed as sensitive and often useless
    • Added exec path - helps to understand how the app is installed
    • Added "notifications app enabled"
    • Added "notify_push app enabled"
    • Added application config
  • New issue template

Some related refactoring

  • os.utils.js is now system.utils.ts, including general system/installation stuff
  • These utils are now constants, not need to call them again all the time
  • They are not used in constants.js to avoid mixing with pure js

🖼️ Screenshots

Before

image

After (light)

image

After (dark)

image

The report

Before

----------------------------System report----------------------------
Nextcloud Talk Desktop version 1.0.0-rc.1
- Built with Nextcloud Talk version 21.0.0-dev.0

Connected to:
- Server address: nextcloud.ltd
- Nextcloud Server version 31.0.0 dev
- Nextcloud Talk version 21.0.0-dev.2

OS: Windows_NT 10.0.26120 (Windows 11 Pro)
----------------------------System report----------------------------

After

Diagnosis report

Nextcloud Talk Desktop
Version v1.0.0-rc.1-55-gacf1314 (heads/fix/help-system-report)
Built-in Talk version v20.0.0-beta.3-941-ge5ee36958 (heads/fix/noid/event-bus-once-garbage)
Operating system Windows_NT 10.0.26120 (Windows 11 Pro)
Executable Path C:\Projects\nc\talk-desktop\node_modules\electron\dist\electron.exe
Connected to -
Nextcloud server version 31.0.0 dev
Nextcloud Talk version 21.0.0-dev.2
notifications app enabled ✅ yes
notify_push app enabled ❌ no

Application config

{
  "theme": "dark",
  "systemTitleBar": false,
  "monochromeTrayIcon": false,
  "zoomFactor": 1,
  "playSoundChat": "respect-dnd",
  "playSoundCall": "respect-dnd"
}

Issue template

Before

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead (🖼️ screenshots often help)

Desktop client

Talk Desktop client version: v1.0.0

Operating system: Windows / MacOS / Ubuntu

Operating system version: Windows 11 / (In case of Linux, provide the distribution.)

Microphone available: yes/no

Camera available: yes/no

Server

Nextcloud version: (see status page: /status.php)

Talk app version: (see apps admin page: /index.php/settings/apps)

Custom Signaling server configured: yes/no and version (see additional admin settings: /index.php/index.php/settings/admin/talk#signaling_server)

Custom TURN server configured: yes/no (see additional admin settings: /index.php/settings/admin/talk#turn_server)

Custom STUN server configured: yes/no (see additional admin settings: /index.php/settings/admin/talk#stun_server)

Logs

Client log

Insert your browser log here, this could for example include:
a) The javascript console log
b) The network log
c) ...

After

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Steps to reproduce

Expected behaviour

Tell us what should happen

Actual behaviour

Tell us what happens instead (🖼️ screenshots often help)

Diagnosis and logs

Diagnosis report

Insert a diagnosis report here.

It can be found in the About window (open from the menu or via F1 and click on "Copy report" button).

Client logs

Press Ctrl+Shift+I or use the context menu to open the developer tools, then go to the Console tab.

Insert error logs here.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added enhancement New feature or request 3. to review labels Nov 21, 2024
@ShGKme ShGKme self-assigned this Nov 21, 2024
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the fix/help-system-report branch from 53ac52c to c6a3c96 Compare November 22, 2024 11:11

<details>
<summary>Client logs</summary>

Press <kbd>Ctrl+Shift+I</kbd> (<kbd>Cmd+Option+C</kbd> on macOS) or use the context menu to open the developer tools, then go to the Console tab.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only this line in the last commit has been changed

@nickvergessen nickvergessen merged commit 63acbe5 into main Nov 22, 2024
10 checks passed
@nickvergessen nickvergessen deleted the fix/help-system-report branch November 22, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants