-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new About window #917
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
nickvergessen
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
53ac52c
to
c6a3c96
Compare
ShGKme
commented
Nov 22, 2024
|
||
<details> | ||
<summary>Client logs</summary> | ||
|
||
Press <kbd>Ctrl+Shift+I</kbd> (<kbd>Cmd+Option+C</kbd> on macOS) or use the context menu to open the developer tools, then go to the Console tab. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only this line in the last commit has been changed
This was referenced Nov 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
Making the About window more useful and beautiful.
Replacing
package.json/version
withgit describe
tag:v1.0.1
v1.0.1-80-g481b5e1 (heads/fix/help-system-report)
Updating the "About" window
notifications
app enabled"notify_push
app enabled"Some related refactoring
os.utils.js
is nowsystem.utils.ts
, including general system/installation stuffconstants.js
to avoid mixing with pure js🖼️ Screenshots
Before
After (light)
After (dark)
The report
Before
After
Diagnosis report
notifications
app enablednotify_push
app enabledApplication config
Issue template
Before
How to use GitHub
Steps to reproduce
Expected behaviour
Tell us what should happen
Actual behaviour
Tell us what happens instead (🖼️ screenshots often help)
Desktop client
Talk Desktop client version: v1.0.0
Operating system: Windows / MacOS / Ubuntu
Operating system version: Windows 11 / (In case of Linux, provide the distribution.)
Microphone available: yes/no
Camera available: yes/no
Server
Nextcloud version: (see status page:
/status.php
)Talk app version: (see apps admin page:
/index.php/settings/apps
)Custom Signaling server configured: yes/no and version (see additional admin settings:
/index.php/index.php/settings/admin/talk#signaling_server
)Custom TURN server configured: yes/no (see additional admin settings:
/index.php/settings/admin/talk#turn_server
)Custom STUN server configured: yes/no (see additional admin settings:
/index.php/settings/admin/talk#stun_server
)Logs
Client log
After
How to use GitHub
Steps to reproduce
Expected behaviour
Tell us what should happen
Actual behaviour
Tell us what happens instead (🖼️ screenshots often help)
Diagnosis and logs
Diagnosis report
Insert a diagnosis report here.
It can be found in the About window (open from the menu or via F1 and click on "Copy report" button).
Client logs
Press Ctrl+Shift+I or use the context menu to open the developer tools, then go to the Console tab.