Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2267 table tweaks #2289

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Fix/2267 table tweaks #2289

merged 2 commits into from
Apr 11, 2022

Conversation

max-nextcloud
Copy link
Collaborator

Summary

Fixes the two main ui issues:

  • make sure text after the table starts on a new line
  • hide actions in read only view

@max-nextcloud
Copy link
Collaborator Author

/compile amend /

@max-nextcloud max-nextcloud mentioned this pull request Apr 11, 2022
8 tasks
@max-nextcloud max-nextcloud requested review from a team, Raudius and julien-nc and removed request for a team April 11, 2022 09:38
@juliusknorr juliusknorr added this to the Nextcloud 24 milestone Apr 11, 2022
@juliusknorr juliusknorr added bug Something isn't working 2. developing labels Apr 11, 2022
@juliusknorr
Copy link
Member

@max-nextcloud Feel free to adjust the label to "to review" once ready :)

@max-nextcloud
Copy link
Collaborator Author

@juliushaertl Good point... let's get this in as it affects the ui and would be nice to have for screencasts etc. The other remaining todo items in the issue are less important for now.

@max-nextcloud
Copy link
Collaborator Author

/rebase

Make sure the following text does not start next to the table.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@max-nextcloud max-nextcloud requested a review from a team April 11, 2022 13:10
@juliusknorr juliusknorr merged commit 5219dab into master Apr 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/2267-table-tweaks branch April 11, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants