fix: keep menubar in one line - prioritize entries #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Prioritized callout and emoji so they are available even on small screens as recommended by @jancborchardt in chat:
|
vinicius73
reviewed
Apr 13, 2022
| :key="icon.label" | ||
| v-tooltip="getLabelAndKeys(icon)" | ||
| :class="getIconClasses(icon)" | ||
| :disabled="disabled(icon)" | ||
| @click="clickIcon(icon)" /> | ||
| <template v-else> | ||
| <div v-show="$index < iconCount || !icon.class" | ||
| <div v-show="icon.priority <= iconCount" |
There was a problem hiding this comment.
Question: can we use v-if instead of v-show?
Suggested change
| <div v-show="icon.priority <= iconCount" | |
| <div v-if="icon.priority <= iconCount" |
There was a problem hiding this comment.
I was not sure so i sticked to what was used. But i think we can use v-if. If the screen is resized new tools will show up or disappear. But that does not mean we have to keep them around all the time. We might as well create / remove them as needed.
vinicius73
approved these changes
Apr 18, 2022
|
/backport to stable24 |
max-nextcloud
force-pushed
the
fix/menubar
branch
from
ebf30d6 to
e4ff2c1
Compare
Menubar entries with submenus cannot be moved to the more-button. Prioritize them when picking the icons for the toolbar. If they still do not fit - do not add them to the more button either they do not work there. This makes sure that the menubar fits in one line and does not overflow. Still prioritizing `undo` and `bold` over `emoji` and `callout`. The former ones are need fairly frequently while the latter not so often. In addition mobile phones have an emoji picker in their text entry. Signed-off-by: Max <max@nextcloud.com>
They cannot be shown in the menu with the remaining tools. Signed-off-by: Max <max@nextcloud.com>
When resizing the browser make sure the three dot menu stays on the same line. Without a buffer it would sometimes wrap even though theoretical there was enough space in the menu bar. No idea what is going on there - but a 4px buffer seems to prevent just that. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
fix/menubar
branch
from
e4ff2c1 to
f131b7d
Compare
mejo-
approved these changes
Apr 19, 2022
This was referenced Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
target version: master, NC24
Menubar entries with submenus cannot be moved to the more-button.
Prioritize them when picking the icons for the toolbar.
If they still do not fit - do not add them to the more button either
they do not work there.
This makes sure that the menubar fits in one line and does not overflow.
Still prioritizing
undoandboldoveremojiandcallout.The former ones are need fairly frequently while the latter not so often.
In addition mobile phones have an emoji picker in their text entry.
Signed-off-by: Max max@nextcloud.com