Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep menubar in one line - prioritize entries #2294

Merged
merged 3 commits into from
Apr 19, 2022
Merged

fix: keep menubar in one line - prioritize entries #2294

merged 3 commits into from
Apr 19, 2022

Commits on Apr 19, 2022

  1. fix: keep menubar in one line - prioritize entries 

    Menubar entries with submenus cannot be moved to the more-button.
Prioritize them when picking the icons for the toolbar.
If they still do not fit - do not add them to the more button either
they do not work there.

This makes sure that the menubar fits in one line and does not overflow.

Still prioritizing `undo` and `bold` over `emoji` and `callout`.
The former ones are need fairly frequently while the latter not so often.
In addition mobile phones have an emoji picker in their text entry.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    2442970 View commit details
    Browse the repository at this point in the history

  2. fix: prioritize emoji and callout 

    They cannot be shown in the menu with the remaining tools.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    75f23a1 View commit details
    Browse the repository at this point in the history

  3. fix: leave some buffer so menubar does not wrap 

    When resizing the browser make sure the three dot menu stays on the same line.
Without a buffer it would sometimes wrap
even though theoretical there was enough space in the menu bar.

No idea what is going on there - but a 4px buffer seems to prevent just that.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud
    max-nextcloud committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    f131b7d View commit details
    Browse the repository at this point in the history