Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] Fix migration from v-tooltip to native title in menu bar buttons ActionEntry #5236

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #5233

- Remove usage of already deleted directive v-tooltip
- Fixed native title text to be the same as was used in tooltip to show shortcuts on desktop

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
It is already added to prototype. Having properties (e.g. computed) for this method in instances throws exception:

> The computed property "t" is already defined as a method.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@backportbot-nextcloud backportbot-nextcloud bot added bug Something isn't working technical debt labels Jan 12, 2024
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 28.0.2 milestone Jan 12, 2024
@ShGKme ShGKme enabled auto-merge January 12, 2024 04:59
@ShGKme ShGKme force-pushed the backport/5233/stable28 branch 2 times, most recently from e1dd55f to ffd8e44 Compare January 12, 2024 06:54
@ShGKme ShGKme merged commit c05a03b into stable28 Jan 12, 2024
98 of 100 checks passed
@ShGKme ShGKme deleted the backport/5233/stable28 branch January 12, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant