diff --git a/lib/Activity/Provider.php b/lib/Activity/Provider.php index 3aa00101..0b4a8991 100644 --- a/lib/Activity/Provider.php +++ b/lib/Activity/Provider.php @@ -29,30 +29,19 @@ use InvalidArgumentException; use OCP\Activity\IEvent; use OCP\Activity\IProvider; -use OCP\ILogger; use OCP\IURLGenerator; use OCP\L10N\IFactory as L10nFactory; class Provider implements IProvider { - /** @var L10nFactory */ - private $l10n; - - /** @var IURLGenerator */ - private $urlGenerator; - - /** @var ILogger */ - private $logger; - /** * @param L10nFactory $l10n * @param IURLGenerator $urlGenerator - * @param ILogger $logger */ - public function __construct(L10nFactory $l10n, IURLGenerator $urlGenerator, ILogger $logger) { - $this->logger = $logger; - $this->urlGenerator = $urlGenerator; - $this->l10n = $l10n; + public function __construct( + private L10nFactory $l10n, + private IURLGenerator $urlGenerator, + ) { } /** diff --git a/tests/Unit/Activity/ProviderTest.php b/tests/Unit/Activity/ProviderTest.php index e7fa18fb..5a2fa63c 100644 --- a/tests/Unit/Activity/ProviderTest.php +++ b/tests/Unit/Activity/ProviderTest.php @@ -31,14 +31,13 @@ use OCA\TwoFactorWebauthn\Activity\Provider; use OCP\Activity\IEvent; use OCP\IL10N; -use OCP\ILogger; use OCP\IURLGenerator; use OCP\L10N\IFactory; +use PHPUnit\Framework\MockObject\MockObject; class ProviderTest extends TestCase { - private $l10n; - private $urlGenerator; - private $logger; + private IFactory&MockObject $l10n; + private IURLGenerator&MockObject $urlGenerator; /** @var Provider */ private $provider; @@ -48,9 +47,8 @@ protected function setUp(): void { $this->l10n = $this->createMock(IFactory::class); $this->urlGenerator = $this->createMock(IURLGenerator::class); - $this->logger = $this->createMock(ILogger::class); - $this->provider = new Provider($this->l10n, $this->urlGenerator, $this->logger); + $this->provider = new Provider($this->l10n, $this->urlGenerator); } public function testParseUnrelated(): void {