Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly cancel and reset ongoing streams when unmounting #1206

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Properly cancel and reset ongoing streams when unmounting #1206

merged 1 commit into from
Apr 13, 2022

Conversation

skjnldsv
Copy link
Member

Fix #894

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews performances Performances issues and optimisations labels Apr 12, 2022
@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Apr 12, 2022
@skjnldsv skjnldsv requested a review from a team April 12, 2022 13:20
@skjnldsv skjnldsv self-assigned this Apr 12, 2022
@skjnldsv skjnldsv requested review from PVince81, artonge and vanpertsch and removed request for a team April 12, 2022 13:20
@skjnldsv skjnldsv mentioned this pull request Apr 12, 2022
Closed
@skjnldsv skjnldsv requested review from pierreozoux and szaimen April 12, 2022 13:23
@skjnldsv
Copy link
Member Author

/rebase

@skjnldsv
Copy link
Member Author

/compile amend /

@skjnldsv @nextcloud-command
Properly cancel and reset ongoing streams when unmounting
27512fc 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv
Copy link
Member Author

/backport to stable23

@skjnldsv
Copy link
Member Author

/backport to stable22

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Apr 12, 2022
@skjnldsv
Copy link
Member Author

/backport to stable21

@szaimen
Copy link
Contributor

szaimen commented Apr 12, 2022

@skjnldsv question: will this now also cancel videos when you switch between multiple?

@skjnldsv
Copy link
Member Author

@skjnldsv question: will this now also cancel videos when you switch between multiple?

It should™ yes :)

@szaimen
Copy link
Contributor

szaimen commented Apr 12, 2022

It should™ yes :)

Cool! will test this branch later and see if it works as promised :)

szaimen
szaimen approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works :)

I verified by uploading a big video, starting it to play, closing it and deleting it. Before this PR it failed to delete the video, now it works :)

@skjnldsv skjnldsv merged commit 92ae401 into master Apr 13, 2022
@skjnldsv skjnldsv deleted the feat/stream-reset-load branch April 13, 2022 06:33
This was referenced Apr 13, 2022
Merged
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Apr 13, 2022
Closed
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Apr 13, 2022
@blizzz blizzz mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

@vanpertsch vanpertsch Awaiting requested review from vanpertsch

@pierreozoux pierreozoux Awaiting requested review from pierreozoux

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug Something isn't working performances Performances issues and optimisations
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

Video files still being load in background even file isn't viewed anymore
2 participants
@skjnldsv @szaimen