-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Workflow Run RO-crate format #19
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
I've built the plugin and ran:
with the following (top level) nextflow.config: plugins {
id 'nf-prov'
}
params {
outdir = 'results'
}
prov {
enabled = true
formats {
wrroc {
file = "${params.outdir}/ro-crate-metadata.json"
overwrite = true
}
}
} And got this ro-crate-metadata.json. For a first commit it's looking pretty good already! Runcrate reads the resulting ro-crate (
I know next to nothing about Nextflow, but my impression is that the outputs are copied to the publishDir "results", mode: 'copy' However, to export as RO-Crate, the relevant files (input, output, workflow, ...) should always be inside the crate's directory tree. This should not depend on the specific workflow, so the plugin needs to take care of this. |
Hi, let us know if you would like some help looking at this. |
Thank you guys for your feedback. It's exactly what I needed to make sure I'm going in the right direction I thought I was going to get to this sooner which is why I didn't respond at the time, but that never happened. Sorry for the radio silence I've been too busy with other priorities to put any time into this, so this will likely not move until I get some free time or someone else picks it up. If you know anyone who would like to work on it, I would be happy to work with them I believe there is also a parallel effort to implement the workflow run crate in the nf-core tooling, might be worth checking in on them |
See also nf-core/tools#2680 @fbartusch may be able to have a look at this |
I worked on most issues @simleo pointed out. |
@fbartusch I suggest that you fork the repo, push a new branch with your changes, then you should be able to make a PR for it. |
@bentsherman I created a PR: #33 |
@fbartusch I've posted my comment on #33 |
Close #6
cc @stain @simleo
Happy to receive any feedback, it's far from complete but wanted to share what I have so far.