Add trailingSemicolon option
#17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
pditommaso
reviewed
Jul 10, 2023
|
I wonder if a semicolon is needed for a single SQL statement. May it can just be removed |
Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
|
I know that MySQL expects it, because of how many times it complained to me in the mysql shell 😆 I would be fine with removing it or adding this option to disable it. Because we aim to support any SQL-like backend, we should not try to adjust the query to fit any particular syntax, or at least we should make the adjustment optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #16