Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.47.0 crashes when changing color for dataset that does not have entropy panel #1690

Closed
kvargha opened this issue Aug 30, 2023 · 3 comments · Fixed by #1691
Closed

v2.47.0 crashes when changing color for dataset that does not have entropy panel #1690

kvargha opened this issue Aug 30, 2023 · 3 comments · Fixed by #1691
Labels
bug Something isn't working

Comments

@kvargha
Copy link

kvargha commented Aug 30, 2023

Current Behavior

A clear and concise description of what is happening / what the bug is.
When I change the color by selection on the UI it causes the page to turn white and logs these errors:
image

Expected behavior

It should highlight the samples by the attribute selected.

How to reproduce

Steps to reproduce the current behavior:

  1. Visit https://nextstrain.org/fetch/storage.googleapis.com/ucsc-gi-cdph-bigtree/CDPH_08_28_2021/CDPH-subtree-0.json
  2. Select any field in the color by selector
  3. The screen should turn white

Your environment: if browsing Nextstrain online

  • Operating system: macOS Ventura 13.4.1
  • Browser: Chrome Version 116.0.5845.110

Additional context

This wasn't happening last week.
@kvargha kvargha added the bug Something isn't working label Aug 30, 2023
@joverlee521
Copy link
Contributor

Hi @kvargha,

Thank you for reporting this issue! This is most likely due to the latest release of Auspice (2.47.0) which we just promoted to use on the production nextstrain.org site this Monday.

I've rolled back the promotion so the issue is fixed on the production site, but the behavior is still visible at https://next.nextstrain.org/fetch/storage.googleapis.com/ucsc-gi-cdph-bigtree/CDPH_08_28_2021/CDPH-subtree-0.json

@joverlee521 joverlee521 changed the title Page turns white when changing color by selection v2.47.0 crashes when changing color for dataset that does not have entropy panel Aug 30, 2023
@kvargha
Copy link
Author

kvargha commented Aug 30, 2023

The issue is gone. Thank you @joverlee521!

@kvargha kvargha closed this as completed Aug 30, 2023
@joverlee521
Copy link
Contributor

Keeping this issue open since we still need to fix the underlying bug within Auspice.

@joverlee521 joverlee521 reopened this Aug 30, 2023
joverlee521 added a commit that referenced this issue Aug 30, 2023
@joverlee521
Replace equalArrays with lodash.isEqual
2c30e0c 
The custom `equalArrays` function can raise an error when one of the
provided arguments does not have a `length` property. Instead of
updating the function, just replace with `lodash.isEqual` which DTRT.

Fixes #1690
@joverlee521 joverlee521 mentioned this issue Aug 30, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace equalArrays with lodash.isEqual nextstrain/auspice
2 participants
@kvargha @joverlee521