Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to show warning text from Auspice JSON #1927

Closed
victorlin opened this issue Jan 14, 2025 · 2 comments · Fixed by #1928
Closed

Add ability to show warning text from Auspice JSON #1927

victorlin opened this issue Jan 14, 2025 · 2 comments · Fixed by #1928
Assignees
Labels
enhancement New feature or request

Comments

@victorlin
Copy link
Member

victorlin commented Jan 14, 2025

from Slack

Render a new JSON entry for warnings (e.g. meta.warning) along the lines of @trvrb's mock-up:

image

Related issues

@victorlin
Copy link
Member Author

Noting that this is somewhat clashing with the existing warning notification framework, but arguably serves a different purpose. The proposed warnings are more about the underlying data than potential programming issues, and meant to persist on the page rather than disappear after a few seconds.

image

@victorlin
Copy link
Member Author

A PR is out for review, but open to suggestions on details such as:

  • Key name – currently meta.warning
  • Placement – currently between byline and sample summary
  • Contents – currently supporting Markdown format
  • Design – currently black text, warning icon, some padding, yellow background, and a more saturated left border.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant