Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing nextflu features #502

Closed
trvrb opened this issue Feb 20, 2018 · 4 comments
Closed

Missing nextflu features #502

trvrb opened this issue Feb 20, 2018 · 4 comments

Comments

@trvrb
Copy link
Member

trvrb commented Feb 20, 2018

Overview

This issue is meant to document features that currently exist on nextflu.org (via https://github.com/blab/nextflu/tree/master/auspice) that should be ported into nextstrain/auspice. Fortunately, we currently use the same flu JSONs for nextflu.org and for nextstrain.org, so that the builds are the same, although nextstrain.org may need some additional info in meta.json to load features.

This looking at migration of nextflu.org to nextstrain.org. Migration of who site is a separate matter and will need attending to after migration of nextflu.org.

I've organized this into:

  • Features necessary to migrate live nextflu.org to nextstrain.org
  • Features that are nice to have but not required
  • HI (titers) features

Necessary

  1. Strain name search. I use this all the time when interacting with nextflu. I'd think this would work like any other filter. Would be amazing to live filter tips as search string is honed in on...
  2. Frequencies. PR Frequencies #497 is a fantastic direction for this.
  3. Annotation of AA mutations to branches. This is way nicer to work with than having to mouseover everything and is critical when digging into flu trees. I would default this to off the way it is on live nextflu.
  4. local branching index colorBy (I'm okay with this being computed in augur rather than live updated in auspice --- might even prefer), clade colorBy

Nice to have

  1. Legend bounds need fixing to be properly rounded like they are on nextflu. The four decimal places with random cuts looks strange.
  2. Nextflu populates genotype colors in a more pleasing fashion so that majority is the pleasing blue-green and mutates are brighter colors. Nextstrain often has the reverse.
  3. Fix colorBy ordering. I think this might be random at the moment (due to dictionaries not being sorted), when there should be a clear ordering, like so: https://github.com/blab/nextflu/blob/master/auspice/_data/color_options.json.
    • EDIT fixed
  4. Allow multiple colorBys
  5. keep controls state if possible - i.e. switching 3y -> 6y should maintain colorBy, tree display...

HI titers (EDIT: will revisit)

  1. Password protection
  2. JSONs (HI, tree, subs) contain egg, cell, hi, fri, center information (i.e. there's 3 JSONs in total). @trvrb @rneher @huddlej to build these / design this schema.
  3. HI distance, subs model, tree model
  4. Titer matrix panel?

Edited to remove LBI

Edited after meeting

@jameshadfield
Copy link
Member

Thanks @trvrb.

4 (colorBys)

  • LBI is already part of live nextstrain (http://www.nextstrain.org/flu/h3n2/ha/3y?c=lbi). Happy for someone to move this code to augur if they would like.
  • How are the clade colorBy attributes set in nextflu? I don't see them in augur:master - if we could export them as a "normal" colorBy then they would be in nextstrain too.

@trvrb
Copy link
Member Author

trvrb commented Feb 21, 2018

Thanks @jameshadfield. I had (obviously) missed LBI. Nice to have it. Clade colorBy is entirely an augur export issue.

@trvrb
Copy link
Member Author

trvrb commented Feb 26, 2018

@jameshadfield: Realized one more thing that should be addressed: where to put the flu reports. This fits into a larger conversation about static content. We should discuss.

@jameshadfield
Copy link
Member

Everything here is fixed / in separate issues. Everything except where to put the flu reports. @trvrb will discuss in person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants