Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix legend ordering #503

Closed
jameshadfield opened this issue Feb 21, 2018 · 1 comment
Closed

fix legend ordering #503

jameshadfield opened this issue Feb 21, 2018 · 1 comment
Assignees
@jameshadfield
Labels
enhancement New feature or request

Comments

@jameshadfield
Copy link
Member

fix legend ordering for genotypes to reflect when particular genotypes were first observed

#497
@jameshadfield jameshadfield added the enhancement New feature or request label Feb 21, 2018
@jameshadfield jameshadfield self-assigned this Feb 21, 2018
This was referenced Feb 27, 2018
Merged
Closed
@trvrb
Copy link
Member

trvrb commented Feb 27, 2018

There are a couple situations where this comes up:

With genotypes, where the ancestral state is not the first thing in the legend.

http://www.nextstrain.org/flu/h3n2/ha/3y?c=gt-HA1_135

freq-1

But also with clades where unassigned is not the first entry in the legend:

http://www.nextstrain.org/flu/vic/ha/12y

freq-2

Generally, I don't think this is a huge issue, but I could imagine eventually separating colorBys into continuous, ordinal and categorical. Examples of continuous are ep and num_date. Examples of ordinal are country (where there's a reason two countries are placed next to each other on the color ramp). Examples of categorical are clade_membership and genotype.

I think just categorical variables would want to be reordered according to tree appearance, while continuous and ordinal should stick to their natural ordering.

@jameshadfield jameshadfield mentioned this issue Apr 9, 2018
Merged
jameshadfield added a commit that referenced this issue Apr 12, 2018
@jameshadfield
Merge branch 'tangle'
dbe8b42 
* tangle:
  remove pan ability from tanglegrams via timout -> reset
  remove pan ability for tanglegrams
  CIs fade out on second tree (bugfix)
  Move 2nd tree selector to Tree Options
  fix CIs on second tree
  Branch clicks (zoom) work for both trees & tangle
  progressive tangle line thickness
  bugfix: minDate sometimes incorrect when loading 2nd tree
  dont allow multiple overlapping trees!
  disable entropy & frequencies upon tree2 load
  improve legend labels. Closes #506.
  Improve calcColorScale. Fixes for tree2. Closes #503.
  reinstate sidebar tree2 loading & simplify tree lifecycle methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jameshadfield jameshadfield

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@trvrb @jameshadfield