-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add legend open/close state to URL query #900
Comments
@jameshadfield you are a mindreader, I had a rant about this just the other day and it's on my 'auspice wish list' door, but I never got around to making an issue 😆 |
The best example to follow for this would be to follow how we currently store the state for being able to control the sidebar open/closed state via the URL query (see https://github.com/nextstrain/auspice/search?q=sidebarOpen&unscoped_q=sidebarOpen). Please note that it's not applicable for this to be set via the dataset JSON. The default state for the legend open/closed should be set as it currently is, and any user-interaction will result in a URL query (via the redux middleware). For instance |
I'm starting work on this now, I expect I'll be able to have a PR for you shortly. |
@jameshadfield I've implemented the setting loading side of this (that is, you can add the Do you also want the legend state to persist to the URL query (e.g. the way the |
Closed by #923 |
Will be very beneficial to iframe embedding and narratives
The text was updated successfully, but these errors were encountered: