temporarily disable integration tests running on GitHub #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are problematic due to subtle differences in fonts across OSs (and maybe other reasons). There are solutions forthcoming which I hope we can implement shortly. However for now it's simpler to disable these from GitHub CI. This commit should be reverted in a feature branch to bring these important tests back.
tihuan
approved these changes
May 29, 2020
jameshadfield
added a commit
that referenced
this pull request
Jun 13, 2023
These weren't being used so I'm reluctantly removing them, so we can remove our dependency on git-lfs, as well as simplifying the repo. These were largely implemented by (fantastic) external collaborators during the early stages of the SARS-CoV-2 pandemic, but we haven't been able to keep developing this type of testing. Hopefully we can resurrect it in the future! Note that Auspice v2.16.0 (2020-05-29) disabled integration tests from our GitHub CI via [PR 1148](#1148). I haven't been running them locally, and I highly doubt anyone else has!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are problematic due to subtle differences in fonts across
OSs (and maybe other reasons). There are solutions forthcoming
which I hope we can implement shortly. However for now it's simpler
to disable these from GitHub CI. This commit should be reverted
in a feature branch to bring these important tests back.
cc @bcoe @tihuan -- you've both done great work here and have suggested
solutions to the problem which I simply haven't had time to get around to addressing.