Webpack hash #1272
Merged
Webpack hash #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kairstenfay
requested review from
jameshadfield,
eharkins and
ivan-aksamentov
jameshadfield
temporarily deployed
to
auspice-webpack-hash-talyotjuq
We noticed irregular behavior in the hashing of our ubndled auspice files [1]. The webpack-chunk-hash (a.k.a. WebpackChunkHash) library appears to have been abandoned by its developers with no commits in the past 4 years. I'm not sure what purpose this library originally served, but after taking a hint from Ivan, it appears that Webpack natively does exactly what we want with respect to chunk hashing and content hashing. Therefore, drop the third party webpack-chunk-hash library from our webpack config in favor of the vanilla webpack API. [1]: #1266
kairstenfay
force-pushed
the
webpack-hash
branch
from
8350ed3 to
252399c
Compare
|
Looks good, thanks! I tested by repeating the steps to reproduce the bug and cherry-picking this commit onto each of the 2 commits examined there (in steps 2 and 10), with the resulting bundles appearing correct. I'll re-test tomorrow using a different method to double check and merge if (as expected) it works. |
Thanks, @jameshadfield ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Drop third party webpack-chunk-hash library which appears to be abandonware and is causing unexpected behavior in our cached auspice files.
Related issue(s)
Fixes #1266
Testing
Follow James's handy list of steps to reproduce the initial bug.
With this patch, the entropy panel is no longer broken when cache is not disabled.
In step 17, the bundles also have identical contents.