Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup metadata headers #1367

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Cleanup metadata headers #1367

merged 1 commit into from
Jul 6, 2021

Conversation

trvrb
Copy link
Member

@trvrb trvrb commented Jul 3, 2021

Description of proposed changes

This commit cleans up naming of metadata headers in downloaded metadata TSV. It does the following:

  1. Keeps headers as input into augur export rather than renaming by title. Thus it has "originating_lab" rather than "Originating lab", "pango_lineage" rather than "PANGO lineage", etc... This should make it easier for people to process downloaded metadata from Auspice alongside metadata provisioned by Nextstrain (via GISAID or via S3).
  2. Makes "date" the second column as this is often what's most important. I couldn't figure out a way to intelligently order remaining fields. My first thought was to use metadata.colorings, but this isn't sorted.
  3. Fixes "accession". It had been exporting as "[object Object]".

Related issue(s)

I discovered these issues while working on #1366. However I thought it best to separate PRs.

Testing

I've tested locally with a number of datasets provisioned by npm run get-data.

This commit cleans up naming of metadata headers in downloaded metadata TSV. It does the following:
1. Keeps headers as input into "augur export" rather than renaming by title. Thus it has "originating_lab" rather than "Originating lab", "pango_lineage" rather than "PANGO lineage", etc... This should make it easier for people to process downloaded metadata from Auspice alongside metadata provisioned by Nextstrain (via GISAID or via S3).
2. Makes "date" the second column as this is often what's most important. I couldn't figure out a way to intelligently order remaining fields. My first thought was to use metadata.colorings, but this isn't sorted.
3. Fixes "accession". It had been exporting as "[object Object]".
@trvrb trvrb requested a review from jameshadfield July 3, 2021 21:19
@jameshadfield jameshadfield temporarily deployed to auspice-metadata-header-xeqrjk July 3, 2021 21:20 Inactive
@trvrb trvrb merged commit 7db03a6 into master Jul 6, 2021
@trvrb trvrb deleted the metadata-header branch July 6, 2021 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants