Inactivate tips when no longer focused #1372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selecting a tip (and the corresponding info panel modal) is intrinsically linked to setting a single active "sample" filter. When clicking away from this modal the filter was removed.
This caused issues in the situation where "a tip is selected under a filter, then you click on that tip to see more information, when you click away to close the box, the filter is removed."
The solution here is to inactivate the sample filters when removing the info panel. This has the benefit (bug?) of keeping a history of clicked tips in the form of inactive filters. (Note that all strain filters can be removed by a single click in the sidebar filter badge.)
Closes #1357
@emmahodcroft could you test this out? There are alternative (harder) solutions where we keep track of whether a clicked tip was previously an inactive filter or not if we want to pursue that. However this PR, in conjunction with #1371, could potentially make @eharkins & Moira's job easier via the following workflow: