Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TravisCI config #1380

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Update TravisCI config #1380

merged 2 commits into from
Jul 16, 2021

Conversation

jameshadfield
Copy link
Member

The npm Auspice 2.29.0 release had integrity shasum errors:

# reported by npm publish running on TravisCI (node.js 10)                               
npm notice integrity:     sha512-zeNaSDrnIgvH6[...]PA0JfybEzP8Ig==
# reported by npm view auspice@2.29.0 after publishing
.integrity: sha512-27B/yNAPP1/vmSoqdBb3g1EMXJW/FLGFWSlTSBl7dDLksHAabqWOYP14aDWF5p4jUuvUNsT20O6G4b3pRcxRAg==

Looking through the TravisCI logs it became clear we were running npm publish for both versions of Node.js we ran TravisCI on, which resulted in one failure each time we released such as

npm ERR! 403 403 Forbidden - PUT https://registry.npmjs.org/auspice - You cannot publish over the previously published versions: 2.29.0.

This PR updates the Node.js versions we run CI on (v10 is no longer maintained), and only runs npm publish when building under v14. It is not clear whether this is related to the integrity shasum errors, or if they were stochastic (or some other 🐛 ).

Node 10 LTS support has ended, so we drop this from the "recommended"
engines. TravisCI also updated to use the three even-numbered releases
currently supported. Currently v12 is in Maintenance LTS, v14 is
Active LTS and v16 is Current.

npm 6.9 is the default version which shipped with NodeJS 12.
Our previous config would run `npm publish` for each node_js
version (previously this was n=2, it's currently n=3). This
resulted in errors as we were trying to publish the same (auspice)
version number multiple times. This may or may not be related to
the integrity shasum errors for auspice 2.29.0.
@jameshadfield jameshadfield temporarily deployed to auspice-travis-yadedg6njxjly86 July 16, 2021 00:20 Inactive
@jameshadfield jameshadfield merged commit dbc73f1 into master Jul 16, 2021
@jameshadfield jameshadfield deleted the travis branch July 16, 2021 00:51
@eharkins
Copy link
Contributor

I would be surprised if there wasn't some stochastic issue involved if this has been happening all along where we try to publish to npm for multiple versions of node and it only just now caused the issue with 2.29.0.

I also noticed this error with respect to updating the docker image: https://travis-ci.com/github/nextstrain/auspice/jobs/524607375#L576 that occured in one of the builds for 2.29.0 but can't say whether it contributed to this issue - it seems relatively unrelated.

@jameshadfield
Copy link
Member Author

I would be surprised if there wasn't some stochastic issue involved if this has been happening all along

That would be my hunch too, but I wanted to take the chance to improve the Travis config here.

Version 2.29.1 was successfully released using the config introduced in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants