Feat/debug narratives #1590
Merged
Feat/debug narratives #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-feat-debug-narr-v5g44s
nextstrain-bot
temporarily deployed
to
auspice-feat-debug-narr-v5g44s
jameshadfield
added a commit
to nextstrain/nextstrain.org
that referenced
this pull request
Nov 3, 2022
Note that this requires a version of auspice which handles this! Auspice will be upgraded in the subsequent commit. See nextstrain/auspice#1590 for the auspice PR which introduces this functionality. See d145a5f#r1012106232 for review comments on this handler.
jameshadfield
force-pushed
the
feat/debug-narratives
branch
3 times, most recently
from
1b7604b to
3ddbd16
Compare
|
This implements new functionality in auspice available at /edit/narratives This represents a release-ready MVP of the functionality and opens Note that a previous version has been tested by @joverlee521 @j23414 & their suggestions have been implemented here. A version of nextstrain.org which uses this PR is available at dev.nextstrain.org/edit/narratives & I suggest testing the functionality there rather than using auspice & localhost:4000, although the latter is also possible |
jameshadfield
added a commit
to nextstrain/nextstrain.org
that referenced
this pull request
Nov 9, 2022
Note that this requires a version of auspice which handles this! Auspice will be upgraded in the subsequent commit. See nextstrain/auspice#1590 for the auspice PR which introduces this functionality. See d145a5f#r1012106232 for review comments on this handler.
tsibley
requested changes
Nov 9, 2022
jameshadfield
force-pushed
the
feat/debug-narratives
branch
from
3ddbd16 to
1adfb5c
Compare
tsibley
approved these changes
Nov 10, 2022
This implements new functionality in auspice available at /edit/narratives where a user can drag&drop a markdown narrative file & see an overview of the slides and the datasets they request, as well as preview the narrative. This represents a release-ready MVP of the functionality and opens the door to a number of possible incremental improvements with the eventual aim of writing and releasing a narrative entirely within- browser. This includes changes motivated by review comments from @tsibley and conversations with @joverlee521 and @j23414
jameshadfield
force-pushed
the
feat/debug-narratives
branch
from
d65415b to
a1b57a2
Compare
|
(Force pushed to rebase onto master, no actual changes since review) |
jameshadfield
added a commit
to nextstrain/nextstrain.org
that referenced
this pull request
Nov 10, 2022
Note that this requires a version of auspice which handles this! Auspice will be upgraded in the subsequent commit. See nextstrain/auspice#1590 for the auspice PR which introduces this functionality. See d145a5f#r1012106232 for review comments on this handler.
jameshadfield
added a commit
to nextstrain/nextstrain.org
that referenced
this pull request
Nov 10, 2022
Note that this requires a version of auspice which handles this! Auspice will be upgraded in the subsequent commit. See nextstrain/auspice#1590 for the auspice PR which introduces this functionality. See d145a5f#r1012106232 for review comments on this handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP (will discuss on slack - just using a PR to get a review app)