Remove integration tests #1672
Merged
Remove integration tests #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These were used for integration tests, which will be addressed in a subsequent commit. Closes #1658 Steps to remove lfs largely followed [this guide](https://gist.github.com/everttrollip/198ed9a09bba45d2663ccac99e662201): ``` $ git lfs uninstall Hooks for this repository have been removed. Global Git LFS configuration has been removed. ``` Change `./gitattributes` to be an empty file ``` $ git lfs ls-files a73b1c9132 * test/integration/__image_snapshots__/Color-by-author-snap.png eb01dd8832 * test/integration/__image_snapshots__/Color-by-country-snap.png c400158ffe * test/integration/__image_snapshots__/Color-by-date-snap.png 73cb500cb5 * test/integration/__image_snapshots__/Color-by-region-snap.png 66b12f3a86 * test/integration/__image_snapshots__/narratives-simultaneous-tree-updates-slide-0-snap.png 1e07b30a4c * test/integration/__image_snapshots__/narratives-simultaneous-tree-updates-slide-1-snap.png 4fe9f78c16 * test/integration/__image_snapshots__/narratives-simultaneous-tree-updates-slide-2-snap.png 864a560bea * test/integration/__image_snapshots__/narratives-simultaneous-tree-updates-slide-3-snap.png f676708c91 * test/integration/__image_snapshots__/narratives-simultaneous-tree-updates-slide-4-snap.png 397b9f6bc3 * test/integration/__image_snapshots__/narratives-simultaneous-tree-updates-slide-5-snap.png abfabba1d2 * test/integration/__image_snapshots__/narratives-simultaneous-tree-updates-slide-6-snap.png ``` `git lfs ls-files | cut -f 3 -d ' ' | xargs git rm --cached`
These weren't being used so I'm reluctantly removing them, so we can remove our dependency on git-lfs, as well as simplifying the repo. These were largely implemented by (fantastic) external collaborators during the early stages of the SARS-CoV-2 pandemic, but we haven't been able to keep developing this type of testing. Hopefully we can resurrect it in the future! Note that Auspice v2.16.0 (2020-05-29) disabled integration tests from our GitHub CI via [PR 1148](#1148). I haven't been running them locally, and I highly doubt anyone else has!
As prompted by `npm audit`. As of Jest 27, jest-circus is the default test runner, so you do not have to install it to use it. The change to jest's ignore patterns addressed a newly introduced error, see [this issue](jestjs/jest#13173).
|
CI failing on node14: Because nullish coalescing assignment is unsupported. Node 14 reached "end-of-life" on 2023-04-30. I'll tackle this in a separate PR and then circle back. |
jameshadfield
force-pushed
the
update-testing
branch
from
d57f03a to
79ce2b5
Compare
jameshadfield
force-pushed
the
engine-updates
branch
from
c11e238 to
9bfac09
Compare
jameshadfield
force-pushed
the
update-testing
branch
from
79ce2b5 to
59b6ac7
Compare
jameshadfield
force-pushed
the
update-testing
branch
from
59b6ac7 to
28f2af0
Compare
1 task
|
Moved commit 59b6ac7 ('Update puppeteer and jest-puppeteer') to #1674 as that requires us dropping support for node.js v14, which this comment indicates might not be possible for a while. This also decouples this PR from #1673. |
victorlin
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details, especially 2047696.
If you had git-lfs installed, you may uninstall it via
git lfs uninstallif needed.Beyond this PR, we should try to stop using GitHub's LFS, but this seems difficult. At the least, this PR will mean we are within the free storage & bandwidth tier.