Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[documentation] Fix typos + update fixture data download instructions #919

Conversation

hydrosquall
Copy link
Contributor

Summary

  • Ran both welcome documents through basic spellcheck.
  • Updated the welcome instructions to download data to the data/ folder, which matches the behavior of the get-data script. This will reduce the number of PRs where someone accidentally commits the datasets/ folde, if they were following the README.md.
  • Didn't know about npm run get-data until seeing the directions in Narrative tables (md or html) need styling #887 (comment), seems link a command that would be useful to document in either README.md or CONTRIBUTING.md as it would lower the startup cost for new developers.

@jameshadfield
Copy link
Member

wonderful - thanks @hydrosquall ⭐️

@jameshadfield jameshadfield merged commit 82eaa0b into nextstrain:master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants