Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/narratives test #618

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Feat/narratives test #618

merged 2 commits into from
Nov 10, 2022

Conversation

jameshadfield
Copy link
Member

This sets up a review app to test the narratives debugger (nextstrain/auspice#1590).

It is a draft as it shouldn't be merged in it's current state!

Note that the changes to nextstrain.org are minimal and amount to routing a single URL pathname towards auspice.

@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-feat-narra-ar05wb October 28, 2022 00:21 Inactive
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-feat-narra-whjtkw October 28, 2022 00:37 Inactive
jameshadfield
jameshadfield commented Oct 28, 2022
View reviewed changes
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-feat-narra-qcf6up October 31, 2022 17:56 Inactive
@victorlin victorlin mentioned this pull request Nov 1, 2022
Closed
@jameshadfield
Copy link
Member Author

@tsibley could I ask you to review d145a5f? (The actual pathname will probably change, so that one day it can expand beyond "just" a debugger.)

tsibley
tsibley requested changes Nov 2, 2022
View reviewed changes
tsibley
tsibley reviewed Nov 2, 2022
View reviewed changes
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-feat-narra-qcf6up November 3, 2022 03:26 Inactive
@nextstrain-bot nextstrain-bot temporarily deployed to nextstrain-s-feat-narra-qcf6up November 4, 2022 00:39 Inactive
@jameshadfield jameshadfield mentioned this pull request Nov 4, 2022
Merged
@jameshadfield
Copy link
Member Author

jameshadfield commented Nov 8, 2022 •
edited
Loading

Testing: dev.nextstrain.org/edit/narratives
RTD: https://nextstrain--139.org.readthedocs.build/en/139/tutorials/narratives-how-to-write.html

To do list:

  • Test this PR on dev.nextstrain.org to check authn works (in progress)
  • Add Jover & Jennifer's suggestions and final changes to the auspice MVP
  • Update docs URLs (review app -> nextstrain.org)
  • Update docs URLs (narrative from staging -> master)
  • release (merge) docs
  • release auspice
  • release new version of nextstrain.org

jameshadfield
jameshadfield commented Nov 9, 2022
View reviewed changes
@jameshadfield jameshadfield marked this pull request as ready for review November 10, 2022 03:11
@jameshadfield
Set up narrative editor/debugger route
d8879ed 
Note that this requires a version of auspice which handles this!
Auspice will be upgraded in the subsequent commit.

See nextstrain/auspice#1590 for the auspice
PR which introduces this functionality.

See d145a5f#r1012106232
for review comments on this handler.
@jameshadfield
upgrade auspice to 2.41.0
726a93a
@jameshadfield jameshadfield merged commit 60a5179 into master Nov 10, 2022
@jameshadfield jameshadfield deleted the feat/narratives-test branch November 10, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsibley tsibley tsibley requested changes

@victorlin victorlin victorlin left review comments

@joverlee521 joverlee521 joverlee521 left review comments

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Nextstrain planning (archived)
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jameshadfield @tsibley @victorlin @joverlee521 @nextstrain-bot