Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make showcase expandable (re-open) #889

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Make showcase expandable (re-open) #889

merged 6 commits into from
Jun 5, 2024

Commits on Jun 5, 2024

  1. Make showcase expandable 

    Previously, the showcase would drop cards as the width decreases. This
is presumably to prevent the showcase from taking up too much height.
Instead of hiding the unused cards, allow them to be accessed by making
the showcase expandable.
    @victorlin
    victorlin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    f7a5c3e View commit details
    Browse the repository at this point in the history

  2. Add expand/collapse transition

    @victorlin
    victorlin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    bd65eba View commit details
    Browse the repository at this point in the history

  3. Remove dupicate CSS style

    @victorlin
    victorlin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    6afb2e1 View commit details
    Browse the repository at this point in the history

  4. Left-align the cards 

    This is the default behavior of justify-content so an alternative is to
simply remove the line, but better to be explicit.

Note: there is a gap on the right side of the cards because the
collection of cards can't be centered with this approach. There are
workarounds¹ that don't use flexbox, but keeping it like this for now.

¹ <https://stackoverflow.com/q/32802202>
    @victorlin
    victorlin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    1db3ee2 View commit details
    Browse the repository at this point in the history

  5. Remove calculation of number of rows 

    This was only necessary to determine if the container is expandable,
which can be determined from the height alone (already used elsewhere).
    @victorlin
    victorlin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    322e385 View commit details
    Browse the repository at this point in the history

  6. Use CSS grid to center the collection of cards 

    Inspired by <https://stackoverflow.com/a/60870221>
    @victorlin
    victorlin committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    0dc2c00 View commit details
    Browse the repository at this point in the history