From c965fec3d35e83397774a023beaea1ccce2947ce Mon Sep 17 00:00:00 2001 From: Hyden Liu Date: Thu, 11 Apr 2024 13:43:23 +0800 Subject: [PATCH 1/2] fix(modal): set the min-height of base height to 100dvh where size equals "full" --- packages/core/theme/src/components/modal.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/core/theme/src/components/modal.ts b/packages/core/theme/src/components/modal.ts index f4869c038f..1e17f1145e 100644 --- a/packages/core/theme/src/components/modal.ts +++ b/packages/core/theme/src/components/modal.ts @@ -111,7 +111,7 @@ const modal = tv({ base: "max-w-5xl", }, full: { - base: "my-0 mx-0 sm:mx-0 sm:my-0 max-w-full h-[100dvh] !rounded-none", + base: "my-0 mx-0 sm:mx-0 sm:my-0 max-w-full h-[100dvh] min-h-[100dvh] !rounded-none", }, }, radius: { From 559bf2501587ee6e36425c6d4f76bd16d6e4dbc5 Mon Sep 17 00:00:00 2001 From: WK Wong Date: Thu, 12 Sep 2024 20:10:40 +0800 Subject: [PATCH 2/2] chore(changeset): add changeset --- .changeset/nervous-mirrors-rule.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/nervous-mirrors-rule.md diff --git a/.changeset/nervous-mirrors-rule.md b/.changeset/nervous-mirrors-rule.md new file mode 100644 index 0000000000..1ca366bece --- /dev/null +++ b/.changeset/nervous-mirrors-rule.md @@ -0,0 +1,5 @@ +--- +"@nextui-org/theme": patch +--- + +set the min-height of base height to 100dvh where size equals `full` (#2681)