Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTDBTK_CLASSIFYWF does not use params.gtdbtk_pplacer_cpus #670

Closed
harper357 opened this issue Sep 13, 2024 · 4 comments
Closed

GTDBTK_CLASSIFYWF does not use params.gtdbtk_pplacer_cpus #670

harper357 opened this issue Sep 13, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@harper357
Copy link
Contributor

Description of the bug

params.gtdbtk_pplacer_cpus can be set, but it currently is not used in the process GTDBTK_CLASSIFYWF.

Re: Slack question

I am happy to make a PR if someone knows/has thoughts on where I should add it. Meaning, should I make a PR on nf-core/modules, just modify conf/module.config and add it to the task.ext.args, or something else?

Command used and terminal output

No response

Relevant files

No response

System information

No response

@harper357 harper357 added the bug Something isn't working label Sep 13, 2024
@jfy133
Copy link
Member

jfy133 commented Sep 18, 2024

Ah crap, I just re-read the issue and saw you offered to do it 🤦 (long two weeks...), that would have made this much faster - I'm really sorry about that @harper357

In the end no need to ask, just go for it (if you don't know for sure, just take a stab), and we go from there!
In th meantime would you be willing to at least review the PR? See above :)

@harper357
Copy link
Contributor Author

No worries. I was actually busy dealing with a different bug that had already been fixed in the dev branch. But I will do that next time.

Reviewed.

@jfy133
Copy link
Member

jfy133 commented Sep 23, 2024

Done in #671

@jfy133 jfy133 closed this as completed Sep 23, 2024
@jfy133
Copy link
Member

jfy133 commented Sep 23, 2024

And thanks!

@jfy133 jfy133 mentioned this issue Oct 2, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants