Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge nf-core template 1.12 #135

Merged
merged 5 commits into from
Nov 24, 2020
Merged

Merge nf-core template 1.12 #135

merged 5 commits into from
Nov 24, 2020

Conversation

skrakau
Copy link
Member

@skrakau skrakau commented Nov 23, 2020

Merge template 1.12

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo

@skrakau skrakau marked this pull request as ready for review November 23, 2020 13:24
d4straub
d4straub approved these changes Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@skrakau skrakau changed the title Merge mf-core template 1.12 Merge nf-core template 1.12 Nov 23, 2020
@skrakau
Copy link
Member Author

skrakau commented Nov 23, 2020

Hi @nf-core/core, the tests are hanging after merging the template and somehow "Run workflow tests (19.10.0) " is still expected. Not sure if I broke something. Does anyone know where this problem is coming from?

drpatelh
drpatelh reviewed Nov 23, 2020
View reviewed changes
main.nf Outdated Show resolved Hide resolved
drpatelh
drpatelh approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @skrakau. The additional test is just a remnant of the previous tests that were being performed. We just need to remove that as a required test in Settings > Branches > dev`. Will do that now.

@skrakau @drpatelh
Update main.nf
8fca699 
Co-authored-by: Harshil Patel <drpatelh@users.noreply.github.com>
@skrakau
Copy link
Member Author

skrakau commented Nov 24, 2020

Thanks @drpatelh !

@skrakau skrakau merged commit d4f9888 into nf-core:dev Nov 24, 2020
@skrakau skrakau deleted the merge-template-1.12 branch May 31, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

@drpatelh drpatelh drpatelh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skrakau @drpatelh @d4straub @nf-core-bot