Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compress unbinned MetaBAT2 output files #172

Merged
merged 5 commits into from
Mar 23, 2021
Merged

Compress unbinned MetaBAT2 output files #172

merged 5 commits into from
Mar 23, 2021

Conversation

skrakau
Copy link
Member

@skrakau skrakau commented Mar 23, 2021 •
edited
Loading

Compress unbinned MetaBAT2 output files (solves #165) and fix depth filename.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@skrakau skrakau requested a review from d4straub March 23, 2021 13:47
d4straub
d4straub reviewed Mar 23, 2021
View reviewed changes
modules/local/metabat2.nf Outdated Show resolved Hide resolved
d4straub
d4straub approved these changes Mar 23, 2021
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please wait for tests though.

@github-actions
Copy link

github-actions bot commented Mar 23, 2021 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 56ed5e8

+| ✅ 116 tests passed       |+
#| ❔   4 tests were ignored |#
!| ❗   4 tests had warnings |!
### ❗ Test warnings:

❔ Tests ignored:

  • files_unchanged - File does not exist: .github/workflows/push_dockerhub_dev.yml
  • files_unchanged - File does not exist: .github/workflows/push_dockerhub_release.yml
  • conda_env_yaml - No environment.yml file found - skipping conda_env_yaml test
  • conda_dockerfile - No environment.yml / Dockerfile file found - skipping conda_dockerfile test

✅ Tests passed:

Run details

  • nf-core/tools version 1.13.1
  • Run at 2021-03-23 14:31:49

@skrakau skrakau merged commit 99e3675 into nf-core:dev Mar 23, 2021
@skrakau skrakau mentioned this pull request Mar 23, 2021
Closed
@skrakau skrakau deleted the dsl2_compress_unbinned branch May 31, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skrakau @d4straub