Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social preview image #35

Merged
merged 3 commits into from
Apr 28, 2020
Merged

Add social preview image #35

merged 3 commits into from
Apr 28, 2020

Conversation

maxulysse
Copy link
Member

  • Add social preview image

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: https://github.com/nf-core/mag/tree/master/.github/CONTRIBUTING.md

@maxulysse maxulysse requested a review from a team February 12, 2020 14:16
@skrakau
Copy link
Member

skrakau commented Apr 20, 2020

Hi,

I am trying to add Github Actions tests to solve the problem above, but as probably expected run into the template linting problem.

Do you know why there is no Template PR created by the nf-core bot for this pipeline? Does one need to trigger this manually or is there a reason this is not done yet?

@ewels
Copy link
Member

ewels commented Apr 21, 2020

It looks like the last sync failed spontaneously:

INFO: Syncing nf-core/mag

ERROR: GitHub API returned code 404: 
{
    "message": "Not Found",
    "documentation_url": "https://developer.github.com/v3/pulls/#create-a-pull-request"
}

ERROR: Sync failed for nf-core/mag:
GitHub API returned code 404: 
{
    "message": "Not Found",
    "documentation_url": "https://developer.github.com/v3/pulls/#create-a-pull-request"
}

I'm not sure why these 404 errors occur - they seem to be basically random as far as I can tell. This sync PR will have to be done manually now anyway, or wait for the next release of tools.

Phil

@skrakau
Copy link
Member

skrakau commented Apr 21, 2020

Thanks for the info! Is there a release of tools planned soon?

@ewels
Copy link
Member

ewels commented Apr 21, 2020

Not super soon - there are still quite a few issues that I would like to get sorted before we push the next release: https://github.com/nf-core/tools/milestone/7 (improving the automated sync, for example).

@HadrienG HadrienG self-requested a review April 28, 2020 15:37
@HadrienG HadrienG merged commit 0dc14ac into nf-core:dev Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants