Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump up BUSCO version to 5.4.3 and escape lack of marker genes #352

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Bump up BUSCO version to 5.4.3 and escape lack of marker genes #352

merged 3 commits into from
Nov 15, 2022

Conversation

alexhbnr
Copy link
Contributor

@alexhbnr alexhbnr commented Nov 15, 2022 •
edited
Loading

This PR addresses two issues:

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@alexhbnr alexhbnr added the bug Something isn't working label Nov 15, 2022
@github-actions
Copy link

github-actions bot commented Nov 15, 2022 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 41633ee

+| ✅ 156 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your prefered methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.6
  • Run at 2022-11-15 12:55:23

@d4straub
Copy link
Collaborator

@nf-core-bot fix linting

d4straub
d4straub approved these changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@d4straub d4straub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Feel free to merge!

@alexhbnr alexhbnr merged commit 0bd574e into nf-core:dev Nov 15, 2022
@alexhbnr
Copy link
Contributor Author

Thanks @d4straub for the quick review!

@alexhbnr alexhbnr deleted the busco_nomarkers branch November 15, 2022 14:58
@alexhbnr alexhbnr mentioned this pull request Nov 15, 2022
Closed
@jfy133 jfy133 mentioned this pull request Feb 27, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4straub d4straub d4straub approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexhbnr @d4straub @nf-core-bot