-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow cram output for parabricks/fq2bam module and remove fastq_align_parabricks #7502
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
I am wondering now: Do we even need a subworkflow if its just a wrapper around one module? 🤔 @maxulysse what do you think? Because for the sarek integration I think I need to chain this anyways with QC? Edit: Subworkflows should combine tools that make up a logical unit in an analysis step. A subworkflow must contain at least two modules. -> I will remove the sbwf |
But it had two modules, aligning and applying the BQSR? |
Yes but I realized that fq2bam already does the BQSR and hence removed it and then its only fq2bam left in the subworkflow. |
In that particular, given that the subworkflow had no extra value, I think it was the good decision to remove it |
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda