Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cram output for parabricks/fq2bam module and remove fastq_align_parabricks #7502

Merged
merged 61 commits into from
Feb 27, 2025

Conversation

famosab
Copy link
Contributor

@famosab famosab commented Feb 19, 2025

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@famosab famosab requested a review from a team as a code owner February 19, 2025 10:28
@famosab famosab added the gpu module uses GPU label Feb 19, 2025
@famosab

This comment was marked as resolved.

@famosab
Copy link
Contributor Author

famosab commented Feb 26, 2025

I am wondering now: Do we even need a subworkflow if its just a wrapper around one module? 🤔 @maxulysse what do you think? Because for the sarek integration I think I need to chain this anyways with QC?

Edit: Subworkflows should combine tools that make up a logical unit in an analysis step. A subworkflow must contain at least two modules. -> I will remove the sbwf

@famosab famosab changed the title Allow cram output for parabricks/fq2bam module and fastq_align_parabricks Allow cram output for parabricks/fq2bam module and remove fastq_align_parabricks Feb 26, 2025
@SPPearce
Copy link
Contributor

I am wondering now: Do we even need a subworkflow if its just a wrapper around one module? 🤔 @maxulysse what do you think? Because for the sarek integration I think I need to chain this anyways with QC?

Edit: Subworkflows should combine tools that make up a logical unit in an analysis step. A subworkflow must contain at least two modules. -> I will remove the sbwf

But it had two modules, aligning and applying the BQSR?

@famosab
Copy link
Contributor Author

famosab commented Feb 26, 2025

I am wondering now: Do we even need a subworkflow if its just a wrapper around one module? 🤔 @maxulysse what do you think? Because for the sarek integration I think I need to chain this anyways with QC?
Edit: Subworkflows should combine tools that make up a logical unit in an analysis step. A subworkflow must contain at least two modules. -> I will remove the sbwf

But it had two modules, aligning and applying the BQSR?

Yes but I realized that fq2bam already does the BQSR and hence removed it and then its only fq2bam left in the subworkflow.

See:
grafik

@maxulysse
Copy link
Member

In that particular, given that the subworkflow had no extra value, I think it was the good decision to remove it

@famosab famosab added this pull request to the merge queue Feb 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2025
@famosab famosab added this pull request to the merge queue Feb 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 27, 2025
@famosab famosab added this pull request to the merge queue Feb 27, 2025
Merged via the queue into nf-core:master with commit 5d0cf64 Feb 27, 2025
16 checks passed
@famosab famosab deleted the pb-cram branch February 27, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpu module uses GPU
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants