Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid use of exit-statements #805

Closed
asp8200 opened this issue Oct 27, 2022 · 1 comment · Fixed by #982
Closed

Avoid use of exit-statements #805

asp8200 opened this issue Oct 27, 2022 · 1 comment · Fixed by #982
Assignees
Labels
enhancement New feature or request input validation
Milestone

Comments

@asp8200
Copy link
Contributor

asp8200 commented Oct 27, 2022

Description of feature

(Not sure if this should be a feature-issue or bug-issue, anyways here goes...)

Version 3.0.2 of Sarek contains a bunch of exit-statement. Here is an example:

exit 1

I recently learned from Marcel Ribeiro-Dantas (@mribeirodantas) that those exit-statements should probably be replaced by exceptions like, say,

throw new Exception("Bad stuff happend")

since "if Nextflow is running in a subprocess of something else, it [an exit-statement] kills the entire thing".

What do you say we replace the exit-statements with exceptions?

@asp8200 asp8200 added the enhancement New feature or request label Oct 27, 2022
@maxulysse maxulysse added this to the 3.2 milestone Feb 21, 2023
@maxulysse
Copy link
Member

cf nf-core/rnaseq#978

@FriederikeHanssen FriederikeHanssen self-assigned this Mar 29, 2023
@FriederikeHanssen FriederikeHanssen moved this from Todo to In Progress in nf-core Hackathon March 2023 Mar 29, 2023
@FriederikeHanssen FriederikeHanssen moved this from In Progress to Ready for review in nf-core Hackathon March 2023 Mar 29, 2023
@FriederikeHanssen FriederikeHanssen linked a pull request Mar 30, 2023 that will close this issue
9 tasks
@github-project-automation github-project-automation bot moved this from Ready for review to Done in nf-core Hackathon March 2023 Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request input validation
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants