Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alternate registry POC #1114

Closed
wants to merge 5 commits into from
Closed

Alternate registry POC #1114

wants to merge 5 commits into from

Conversation

maxulysse
Copy link
Member

idea to replace #1113

Another idea that will need to modify all modules in the modules repo + some tools magic, but greatly simplify update and maintenance of the public_aws_ecr file, and any other similar things

adamrtalbot
adamrtalbot reviewed Jun 16, 2023
View reviewed changes
Copy link
Contributor

@adamrtalbot adamrtalbot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you reckon it's possible to make a method in lib?

container "${ set_docker_container(
                    singularity   = 'https://depot.galaxyproject.org/singularity/ubuntu:20.04'
                    docker        = 'quay.io/nf-core/ubuntu:20.04'
                    dockershort   = 'nf-core/ubuntu:20.04'
                )
            }

conf/public_aws_ecr.config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could add this to the general conf/modules.config

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we can ditch this profile entirely. The rule would be docker.registry = <whatever> then if you have a complete mirror you can add this as a config:

process {
    ext.container_full_uri = false
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea

@adamrtalbot adamrtalbot mentioned this pull request Jun 16, 2023
Closed
10 tasks
@github-actions
Copy link

nf-core lint overall result: Passed ✅

Posted for pipeline commit 2640971

+| ✅ 154 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.8
  • Run at 2023-06-16 07:50:30

@maxulysse
Copy link
Member Author

closed in favor of #1118

@maxulysse maxulysse closed this Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamrtalbot adamrtalbot adamrtalbot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @adamrtalbot