Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Improve schema usage for input #1243

Merged
merged 2 commits into from
Sep 18, 2023
Merged

FEAT: Improve schema usage for input #1243

merged 2 commits into from
Sep 18, 2023

Conversation

maxulysse
Copy link
Member

@github-actions
Copy link

github-actions bot commented Sep 18, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅

Posted for pipeline commit b1407ba

+| ✅ 143 tests passed       |+
#| ❔   9 tests were ignored |#

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-09-18 09:55:13

FriederikeHanssen
FriederikeHanssen reviewed Sep 18, 2023
View reviewed changes
nextflow_schema.json
Comment on lines -29 to -32
{
"type": "boolean",
"enum": ["false"]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't this done so --step would work without input?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just tried it locally with:

nextflow run . -profile test,docker --outdir results

followed by:

nextflow run . -profile test,docker --outdir results --input false --step recalibrate

and it worked without failures.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally yes, but we fixed it in nf-validation, now parameters evaluating to false are not validated

@maxulysse maxulysse merged commit 607ecd6 into dev Sep 18, 2023
20 checks passed
@maxulysse maxulysse deleted the improve_nextflow_schema branch September 18, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen left review comments

@mirpedrol mirpedrol mirpedrol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @mirpedrol @FriederikeHanssen