Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding labels to the local modules #1287

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Adding labels to the local modules #1287

merged 3 commits into from
Oct 17, 2023

Conversation

asp8200
Copy link
Contributor

@asp8200 asp8200 commented Oct 16, 2023

Adding labels to local processes.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Oct 16, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 59b0793

+| ✅ 147 tests passed       |+
#| ❔   8 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in WorkflowSarek.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-16 17:01:04

@asp8200 asp8200 marked this pull request as ready for review October 16, 2023 15:14
FriederikeHanssen
FriederikeHanssen reviewed Oct 16, 2023
View reviewed changes
modules/local/add_info_to_vcf/main.nf Outdated
@@ -1,5 +1,6 @@
process ADD_INFO_TO_VCF {
tag "$meta.id"
label 'process_low'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be process_single, it only needs one core, right?

FriederikeHanssen
FriederikeHanssen requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are all super low effort processes, so I guess we can trim ressource requests even more?

@asp8200
Copy link
Contributor Author

asp8200 commented Oct 16, 2023

they are all super low effort processes, so I guess we can trim ressource requests even more?

Should I set the label to process_single for all three processes?

Do you have any other recommendation

@maxulysse
Copy link
Member

That's probably a smart idea too

@maxulysse maxulysse merged commit 53d0037 into nf-core:dev Oct 17, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen requested changes

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asp8200 @maxulysse @FriederikeHanssen