Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix annotation tests #143

Merged
merged 6 commits into from
Mar 5, 2020
Merged

fix annotation tests #143

merged 6 commits into from
Mar 5, 2020

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse
Copy link
Member Author

I'll revert the snpeff DB to GRCh37.75 and GRCh38.86

Because even if there are actually files to download for GRCh37.87 and GRCh38.92:

I'm getting these errors when I actually try to download them:

> snpEff download -v GRCh38.92
00:00:00	SnpEff version SnpEff 4.3t (build 2017-11-24 10:18), by Pablo Cingolani
00:00:00	Command: 'download'
00:00:00	Reading configuration file 'snpEff.config'. Genome: 'GRCh38.92'
00:00:00	Reading config file: /home/maxime/workspace/nf-core_sarek/snpEff.config
00:00:00	Reading config file: /opt/conda/envs/nf-core-sarek-dev/share/snpeff-4.3.1t-3/snpEff.config
java.lang.RuntimeException: Property: 'GRCh38.92.genome' not found
	at org.snpeff.interval.Genome.<init>(Genome.java:106)
	at org.snpeff.snpEffect.Config.readGenomeConfig(Config.java:681)
	at org.snpeff.snpEffect.Config.readConfig(Config.java:649)
	at org.snpeff.snpEffect.Config.init(Config.java:480)
	at org.snpeff.snpEffect.Config.<init>(Config.java:117)
	at org.snpeff.SnpEff.loadConfig(SnpEff.java:451)
	at org.snpeff.snpEffect.commandLine.SnpEffCmdDownload.runDownloadGenome(SnpEffCmdDownload.java:80)
	at org.snpeff.snpEffect.commandLine.SnpEffCmdDownload.run(SnpEffCmdDownload.java:72)
	at org.snpeff.SnpEff.run(SnpEff.java:1183)
	at org.snpeff.SnpEff.main(SnpEff.java:162)
00:00:02	Logging
00:00:03	Done.

> snpEff download -v GRCh37.87
00:00:00	SnpEff version SnpEff 4.3t (build 2017-11-24 10:18), by Pablo Cingolani
00:00:00	Command: 'download'
00:00:00	Reading configuration file 'snpEff.config'. Genome: 'GRCh37.87'
00:00:00	Reading config file: /home/maxime/workspace/nf-core_sarek/snpEff.config
00:00:00	Reading config file: /opt/conda/envs/nf-core-sarek-dev/share/snpeff-4.3.1t-3/snpEff.config
java.lang.RuntimeException: Property: 'GRCh37.87.genome' not found
	at org.snpeff.interval.Genome.<init>(Genome.java:106)
	at org.snpeff.snpEffect.Config.readGenomeConfig(Config.java:681)
	at org.snpeff.snpEffect.Config.readConfig(Config.java:649)
	at org.snpeff.snpEffect.Config.init(Config.java:480)
	at org.snpeff.snpEffect.Config.<init>(Config.java:117)
	at org.snpeff.SnpEff.loadConfig(SnpEff.java:451)
	at org.snpeff.snpEffect.commandLine.SnpEffCmdDownload.runDownloadGenome(SnpEffCmdDownload.java:80)
	at org.snpeff.snpEffect.commandLine.SnpEffCmdDownload.run(SnpEffCmdDownload.java:72)
	at org.snpeff.SnpEff.run(SnpEff.java:1183)
	at org.snpeff.SnpEff.main(SnpEff.java:162)
00:00:02	Logging
00:00:03	Done.

@maxulysse maxulysse self-assigned this Mar 5, 2020
@maxulysse maxulysse merged commit ee4f5b0 into nf-core:dev Mar 5, 2020
@maxulysse maxulysse deleted the FixAnnotationCI branch March 5, 2020 10:44
@maxulysse maxulysse mentioned this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants