Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve minimal usage of Sarek #180

Merged
merged 3 commits into from
Apr 15, 2020
Merged

improve minimal usage of Sarek #180

merged 3 commits into from
Apr 15, 2020

Conversation

maxulysse
Copy link
Member

nf-core/sarek pull request

Many thanks for contributing to nf-core/sarek!

Please fill in the appropriate checklist below (delete whatever is not relevant).
These are the most common things requested on pull requests (PRs).

PR checklist

  • This comment contains a description of changes (with reason)
  • If you've fixed a bug or added code that should be tested, add tests!
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repo
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Make sure your code lints (nf-core lint .).
  • Documentation in docs is updated
  • CHANGELOG.md is updated
  • README.md is updated

Learn more about contributing: CONTRIBUTING.md

@maxulysse maxulysse added the enhancement New feature or request label Apr 15, 2020
@maxulysse maxulysse added this to the 2.6 milestone Apr 15, 2020
@maxulysse maxulysse requested a review from a team April 15, 2020 09:59
@maxulysse maxulysse self-assigned this Apr 15, 2020
ggabernet
ggabernet approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, it will be great to be able to start with the indexed BAMs as well!

@maxulysse maxulysse merged commit 6fc455a into nf-core:dev Apr 15, 2020
@maxulysse maxulysse deleted the Bee branch April 15, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet approved these changes

@mahesh-panchal mahesh-panchal Awaiting requested review from mahesh-panchal

Assignees

@maxulysse maxulysse

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.6
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @ggabernet