Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bcftools sort step before tabix index #432

Merged
merged 2 commits into from
Jan 20, 2022

Conversation

priesgo
Copy link
Contributor

@priesgo priesgo commented Sep 30, 2021

Add bcftools sort step before tabix index to deal with different Unix sort versions in the Concatenate_VCFs.sh script.

The motivation for this PR was making Sarek work in my system using a conda environment, not docker. My system is GNU core utils version 8.22. Tabix was complaining about the order of chromosomes after concatenation, sorting the VCF before calling tabix fixes the issue.

This is the particular command I used:

nextflow run tron-bioinformatics/sarek -r $SAREK_VERSION --input $input --outdir $output \
--step variant_calling --tools HaplotypeCaller \
--genome custom \
--fasta $REFERENCE_GENOME_FASTA --fasta_fai $REFERENCE_GENOME_FASTA_INDEX \
--dict $REFERENCE_GENOME_DICT \
--intervals $BED \
--dbsnp $DBSNP --dbsnp_tbi $DBSNP_TABIX \
--germline_resource $GNOMAD \
--igenomes_ignore \
 -profile conda,standard,finish

@bhagesh-h
Copy link

Hi @priesgo I have submitted a pull request for the same issue, details can be found here:
#442 (comment)

Hope it gets integrated.

@priesgo
Copy link
Contributor Author

priesgo commented Oct 16, 2021

Indeed same issue, similar solution. Whoever reviews, please, merge one, close the other.

Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, sorry it toook so long. I am integrating the changes now. @bhagesh-codebeast chose to integrate this PR, because i can merge it without solving any conflicts. The solution is similar :) Thanks a lot for contributing this

@priesgo
Copy link
Contributor Author

priesgo commented Mar 29, 2022

Welcome @FriederikeHanssen, happy that it went in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants