improve subway map #531
Merged
improve subway map #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FriederikeHanssen
approved these changes
May 2, 2022
There was a problem hiding this comment.
Couple of things (unrelated to this particular PR, but general about this map):
7should be bcftools/vcftools & it is only run on VC output so could be moved up to before annotation- VEP/Snpeff generate their own reports added to MQC
1Should also be FastQC3I think can go, or moved into the convert branch (but I don't think anything runs their)5should also have samtools
BUt could also go into as separate PR.
|
Merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to take into account that germline sample in a pair T/N undergoes the germline variant calling line as well.