Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add step markduplicates & allow BAM input for all steps #536

Merged
merged 69 commits into from
May 12, 2022

Conversation

FriederikeHanssen
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
conf/test.config Outdated Show resolved Hide resolved
@maxulysse
Copy link
Member

why not adding DEEPTOOLS_BAMCOVERAGE to nf-core/cram_qc.nf and control in conf/modules.config which qc tools we use?

@FriederikeHanssen
Copy link
Contributor Author

why not adding DEEPTOOLS_BAMCOVERAGE to nf-core/cram_qc.nf and control in conf/modules.config which qc tools we use?

hm yeah that would work, or I thought also that we could rewrite bam_qc to run the QC tools on cram both and just control SAMTOOLS_BAMTOCRAM whether it is cram input or not.

@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review May 12, 2022 13:35
@FriederikeHanssen FriederikeHanssen changed the title Add step markduplicates Add step markduplicates & allow BAM input for all steps May 12, 2022
Copy link

@marissaDubbelaar marissaDubbelaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two minor suggestions

workflows/sarek.nf Show resolved Hide resolved
workflows/sarek.nf Outdated Show resolved Hide resolved
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Looks good to me! I've just thought that if you changed that the step prepare_recalibration works maybe that should also be added to the docs, but maybe you plan to add all docs in a separate PR, that's also fine :)

@FriederikeHanssen
Copy link
Contributor Author

Hey Looks good to me! I've just thought that if you changed that the step prepare_recalibration works maybe that should also be added to the docs, but maybe you plan to add all docs in a separate PR, that's also fine :)

Yes I am planning to do everything in the docs at once, but it is probably a good idea to at least put a note into the docs so i won't loose track.

Thanks a lot for reviewing 🙏

@FriederikeHanssen FriederikeHanssen merged commit b76d09d into nf-core:dev May 12, 2022
@FriederikeHanssen FriederikeHanssen deleted the step_md branch July 10, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants