-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add step markduplicates & allow BAM input for all steps #536
Conversation
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
why not adding |
hm yeah that would work, or I thought also that we could rewrite bam_qc to run the QC tools on cram both and just control SAMTOOLS_BAMTOCRAM whether it is cram input or not. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, two minor suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Looks good to me! I've just thought that if you changed that the step prepare_recalibration
works maybe that should also be added to the docs, but maybe you plan to add all docs in a separate PR, that's also fine :)
Yes I am planning to do everything in the docs at once, but it is probably a good idea to at least put a note into the docs so i won't loose track. Thanks a lot for reviewing 🙏 |
PR checklist
scrape_software_versions.py
nf-core lint .
).nextflow run . -profile test,docker
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).