Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mutect2 #544

Merged
merged 19 commits into from
May 16, 2022
Merged

Fix Mutect2 #544

merged 19 commits into from
May 16, 2022

Conversation

FriederikeHanssen
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@FriederikeHanssen FriederikeHanssen changed the title nf-core modules update -all Fix Mutect2 May 13, 2022
@FriederikeHanssen FriederikeHanssen marked this pull request as ready for review May 16, 2022 10:03
@ggabernet ggabernet self-requested a review May 16, 2022 15:13
ggabernet
ggabernet approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I just had a suggestion!

subworkflows/local/pair_variant_calling.nf Show resolved Hide resolved
subworkflows/local/tumor_variant_calling.nf Show resolved Hide resolved
@FriederikeHanssen FriederikeHanssen merged commit 5d0a0b9 into nf-core:dev May 16, 2022
@FriederikeHanssen FriederikeHanssen deleted the fix_mutect2 branch July 10, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggabernet ggabernet ggabernet approved these changes

@maxulysse maxulysse Awaiting requested review from maxulysse maxulysse is a code owner

@GCJMackenzie GCJMackenzie Awaiting requested review from GCJMackenzie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FriederikeHanssen @ggabernet