Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cnvkit germline mode #576

Merged
merged 20 commits into from
Jun 7, 2022
Merged

Add cnvkit germline mode #576

merged 20 commits into from
Jun 7, 2022

Conversation

SusiJo
Copy link
Contributor

@SusiJo SusiJo commented Jun 1, 2022

PR checklist

This PR implements germline variant calling with cnvkit.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
    • If you've added a new tool - add to the software_versions process and a regex to scrape_software_versions.py
    • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
    • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint .).
  • Ensure the test suite passes (nextflow run . -profile test,docker).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@SusiJo SusiJo requested a review from maxulysse as a code owner June 1, 2022 16:06
@SusiJo
Copy link
Contributor Author

SusiJo commented Jun 1, 2022

Please note that the new upstream nf-core/modules cnvkit/batch has to be installed after the PR to modules is merged.

maxulysse
maxulysse reviewed Jun 2, 2022
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FriederikeHanssen
FriederikeHanssen reviewed Jun 3, 2022
View reviewed changes
Copy link
Contributor

@FriederikeHanssen FriederikeHanssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, only thing missing would be some CI tests. 🚀

@maxulysse
Copy link
Member

@SusiJo you can run prettier with @nf-core-bot fix linting

@SusiJo
Copy link
Contributor Author

SusiJo commented Jun 3, 2022

Ah cool! Good to know for next time :D

@SusiJo @maxulysse
Update subworkflows/local/germline_variant_calling.nf
2eb63ce 
Co-authored-by: Maxime U. Garcia <maxime.garcia@scilifelab.se>
maxulysse
maxulysse approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

FriederikeHanssen
FriederikeHanssen reviewed Jun 3, 2022
View reviewed changes
tests/test_tools.yml
- path: results/variant_calling/sample1/cnvkit/test.paired_end.recalibrated.sorted.cnr
- path: results/variant_calling/sample1/cnvkit/test.paired_end.recalibrated.sorted.cns
- path: results/variant_calling/sample1/cnvkit/test.paired_end.recalibrated.sorted.call.cns

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks for adding those <3

@maxulysse
Copy link
Member

CI tests are badly failing

@FriederikeHanssen
Copy link
Contributor

linting fails for cnvkit bathc:

│ cnvkit/batch                              │ modules/nf-co… │ Local copy of   │
│                                           │                │ module does not │
│                                           │                │ match remote

could that be the reason?

@maxulysse
Copy link
Member

Seems likely, anyway error message is not helping as usual...

@maxulysse maxulysse merged commit 205b33f into nf-core:dev Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FriederikeHanssen FriederikeHanssen FriederikeHanssen left review comments

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SusiJo @maxulysse @FriederikeHanssen