From c5c190164ee72ea28c516b5861c5a0ab1abb6956 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BAlia=20Mir=20Pedrol?= Date: Tue, 19 Apr 2022 17:04:40 +0200 Subject: [PATCH 1/2] don't updatate sha if the module is not updated --- nf_core/modules/update.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/nf_core/modules/update.py b/nf_core/modules/update.py index 1967ac55a4..f2011f0d66 100644 --- a/nf_core/modules/update.py +++ b/nf_core/modules/update.py @@ -428,12 +428,6 @@ class DiffEnum(enum.Enum): if not dry_run: self.update_modules_json(modules_json, modules_repo.name, module, version) - # Don't save to a file, just iteratively update the variable - else: - modules_json = self.update_modules_json( - modules_json, modules_repo.name, module, version, write_file=False - ) - if self.save_diff_fn: # Compare the new modules.json and build a diff modules_json_diff = difflib.unified_diff( From f26c2d4fd3cf42a4fed86d1711ab2ba1f88b79b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=BAlia=20Mir=20Pedrol?= Date: Wed, 20 Apr 2022 10:16:30 +0200 Subject: [PATCH 2/2] modify changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9fc9e1067d..2396490ff6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,7 @@ - Bumped the minimum version of `rich` from `v10` to `v10.7.0` - Add an empty line to `modules.json`, `params.json` and `nextflow-schema.json` when dumping them to avoid prettier errors. +- Fix bug in modules.json when a module is not updated ([#1518](https://github.com/nf-core/tools/pull/1518)) ### Modules