From 87f15b6c0188a0dc0013a774a8c9867f4446aba4 Mon Sep 17 00:00:00 2001 From: mirpedrol Date: Sun, 27 Nov 2022 15:54:48 +0100 Subject: [PATCH 1/2] allow other urls not starting with http --- nf_core/modules/modules_json.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/nf_core/modules/modules_json.py b/nf_core/modules/modules_json.py index aafd7965ea..bad80631d3 100644 --- a/nf_core/modules/modules_json.py +++ b/nf_core/modules/modules_json.py @@ -477,7 +477,12 @@ def has_git_url_and_modules(self): elif ( not isinstance(repo_url, str) or repo_url == "" - or not repo_url.startswith("http") + or not ( + repo_url.startswith("http") + or repo_url.startswith("ftp") + or repo_url.startswith("ssh") + or repo_url.startswith("git") + ) or not isinstance(repo_entry["modules"], dict) or repo_entry["modules"] == {} ): From 96fba460e46bd8eb923e52c1d8f29a04ba234da0 Mon Sep 17 00:00:00 2001 From: mirpedrol Date: Sun, 27 Nov 2022 15:59:32 +0100 Subject: [PATCH 2/2] modify changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b0ae4b39fc..8c39115f5d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -38,6 +38,7 @@ - Substitute ModulesCommand and SubworkflowsCommand by ComponentsCommand ([#2000](https://github.com/nf-core/tools/pull/2000)) - Don't print source file + line number on logging messages (except when verbose) ([#2015](https://github.com/nf-core/tools/pull/2015)) - Extended the chat notifications to Slack ([#1829](https://github.com/nf-core/tools/pull/1829)) +- Allow other remote URLs not starting with `http` ([#2061](https://github.com/nf-core/tools/pull/2061)) ### Modules