Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix create-test-yml #1161

Merged
merged 1 commit into from
Jul 7, 2021
Merged

fix create-test-yml #1161

merged 1 commit into from
Jul 7, 2021

Conversation

KevinMenden
Copy link
Contributor

Fix bug in nf-core modules create-test-yml that occurs when specifying the output directory.

Now the simply doesn't compare md5 sums when a output directory is specified. Otherwise we'd have to ask the user for two directories which gets a bit much. The best way is to run it without a specified directory anyway.

Fixes #1148

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@KevinMenden KevinMenden linked an issue Jul 6, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #1161 (6876b7e) into dev (5e9e33c) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1161   +/-   ##
=======================================
  Coverage   69.22%   69.23%           
=======================================
  Files          50       50           
  Lines        5232     5233    +1     
=======================================
+ Hits         3622     3623    +1     
  Misses       1610     1610           
Impacted Files Coverage Δ
nf_core/modules/test_yml_builder.py 45.98% <66.66%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9e33c...6876b7e. Read the comment docs.

Copy link
Contributor

@ErikDanielsson ErikDanielsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@KevinMenden KevinMenden merged commit f7da9ca into nf-core:dev Jul 7, 2021
@KevinMenden KevinMenden deleted the fix-test-yml branch July 7, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nf-core create-test-yml fails when given output directory
2 participants