From 263a5d3f23ad1b7372d2f31f5ad92bc7bc041b75 Mon Sep 17 00:00:00 2001 From: mirpedrol Date: Wed, 14 Jun 2023 17:34:22 +0200 Subject: [PATCH 1/2] don't update modules_json if module is not updated --- nf_core/components/update.py | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/nf_core/components/update.py b/nf_core/components/update.py index 5f8a2129c5..6fc6e03544 100644 --- a/nf_core/components/update.py +++ b/nf_core/components/update.py @@ -306,16 +306,6 @@ def update(self, component=None, silent=False, updated=None, check_diff_exist=Tr # Update linked components self.update_linked_components(modules_to_update, subworkflows_to_update, updated) self.manage_changes_in_linked_components(component, modules_to_update, subworkflows_to_update) - else: - # Don't save to a file, just iteratively update the variable - self.modules_json.update( - self.component_type, - modules_repo, - component, - version, - installed_by=None, - write_file=False, - ) if self.save_diff_fn: # Write the modules.json diff to the file From 84f807a1efeead55e9a7b0506e3783c669b395dc Mon Sep 17 00:00:00 2001 From: mirpedrol Date: Wed, 14 Jun 2023 17:48:25 +0200 Subject: [PATCH 2/2] update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ae87ef96e3..1a909ccf07 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -27,6 +27,8 @@ ### Modules +- Don't update `modules_json` object if a module is not updated ([#2323](https://github.com/nf-core/tools/pull/2323)) + ### Subworkflows ### General