Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master<-Dev for release of v1.13.3 #964

Merged
merged 33 commits into from
Mar 25, 2021
Merged

Master<-Dev for release of v1.13.3 #964

merged 33 commits into from
Mar 25, 2021

Conversation

KevinMenden
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #964 (e7fd780) into master (afa4a8b) will decrease coverage by 0.26%.
The diff coverage is 40.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
- Coverage   69.56%   69.30%   -0.27%     
==========================================
  Files          34       34              
  Lines        4196     4225      +29     
==========================================
+ Hits         2919     2928       +9     
- Misses       1277     1297      +20     
Impacted Files Coverage Δ
nf_core/lint/__init__.py 77.29% <ø> (ø)
nf_core/modules/test_yml_builder.py 16.04% <8.69%> (-0.15%) ⬇️
nf_core/modules/create.py 59.57% <62.06%> (-1.35%) ⬇️
nf_core/__main__.py 61.26% <100.00%> (ø)
nf_core/lint/version_consistency.py 10.52% <100.00%> (+4.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afa4a8b...e7fd780. Read the comment docs.

apeltzer and others added 2 commits March 24, 2021 15:49
allow module names with notations as in conda
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that you've tested the modules commands fully, I'm happy with this - code looks good as far as I can see 👍🏻

Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copper Crocodile The Resurrection!

Copy link
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but not really a lot of time to review everything in detail :-(

Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the way to provide the paths has changed for the modules, this should be also changed in the template.
Testing it now, and it was still providing the paths the old way. See discussion in #tools channel :)

@ewels ewels requested a review from ggabernet March 25, 2021 12:20
Copy link
Member

@ggabernet ggabernet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, too many meetings today. Looks great now!

@KevinMenden KevinMenden merged commit d0a6649 into master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants