-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master<-Dev for release of v1.13.3 #964
Conversation
Bump to v1.14dev, move NXF_VER up in scope in sync wf
Fix bug in lint with release mode
improve test-yml builder
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
==========================================
- Coverage 69.56% 69.30% -0.27%
==========================================
Files 34 34
Lines 4196 4225 +29
==========================================
+ Hits 2919 2928 +9
- Misses 1277 1297 +20
Continue to review full report at Codecov.
|
bump version to 1.13.3
allow module names with notations as in conda
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming that you've tested the modules commands fully, I'm happy with this - code looks good as far as I can see 👍🏻
tweak TODO string in test_yml_builder.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copper Crocodile The Resurrection!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine but not really a lot of time to review everything in detail :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the way to provide the paths has changed for the modules, this should be also changed in the template.
Testing it now, and it was still providing the paths the old way. See discussion in #tools channel :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, too many meetings today. Looks great now!
Extra lint test with --release
No description provided.