Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:page-header): breadcrumb display error menu if component without parameters #276

Merged
merged 3 commits into from
Nov 17, 2018
Merged

fix(module:page-header): breadcrumb display error menu if component without parameters #276

merged 3 commits into from
Nov 17, 2018

Conversation

taogeT
Copy link
Contributor

@taogeT taogeT commented Nov 14, 2018

fix(module:page-header): breadcrumb display error if one component with several menus.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

If a route is like the following situation:

{ path: '/example/:id', component: ExampleComponent}

And several menus are like the following configuration:

{ "text": "A Path", "link": "/example/1" }    
{ "text": "B Path", "link": "/example/2" }    

And ExampleComponent's template use module page-header without any parameters( such as <page-header></page-header> ),

When route had changed from menu "A Path" to menu "B Path", the breadcrumb still shown "A Path".

What is the new behavior?

Breadcrumb will show correct menu name.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Copy link
Member

@cipchk cipchk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Please add unit test.

packages/abc/page-header/page-header.component.ts Outdated Show resolved Hide resolved
packages/abc/page-header/page-header.component.ts Outdated Show resolved Hide resolved
@cipchk cipchk merged commit 72a75ea into ng-alain:master Nov 17, 2018
@taogeT taogeT deleted the dev-fix-page-header branch November 19, 2018 07:22
@taogeT taogeT restored the dev-fix-page-header branch November 23, 2018 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants