Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:st): support response body is an array type #327

Merged
merged 4 commits into from
Dec 18, 2018
Merged

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Dec 18, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov-io
Copy link

codecov-io commented Dec 18, 2018

Codecov Report

Merging #327 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
+ Coverage   94.47%   94.48%   +<.01%     
==========================================
  Files         227      227              
  Lines        6061     6071      +10     
  Branches      976      980       +4     
==========================================
+ Hits         5726     5736      +10     
  Misses        256      256              
  Partials       79       79
Impacted Files Coverage Δ
packages/abc/table/table.component.ts 97.46% <100%> (+0.01%) ⬆️
packages/abc/table/table-data-source.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8a6695...3148ac6. Read the comment docs.

@cipchk cipchk merged commit 4e681dc into master Dec 18, 2018
@cipchk cipchk deleted the dev-st-url branch December 22, 2018 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants